Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New NTP recipe #182

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@chrissnell
Copy link
Contributor

commented Feb 12, 2015

A recipe for the NTP check. Uses the new style Ruby->JSON->YAML configuration translation.

@miketheman

This comment has been minimized.

Copy link
Collaborator

commented Feb 12, 2015

Nice work! Any chance of some tests?

@miketheman miketheman added the feature label Feb 12, 2015

@miketheman miketheman added this to the Next minor milestone Feb 12, 2015

@coveralls

This comment has been minimized.

Copy link

commented Feb 12, 2015

Coverage Status

Coverage remained the same at 100.0% when pulling 806f0d0 on chrissnell:ntp into b2824ae on DataDog:master.

@miketheman

This comment has been minimized.

Copy link
Collaborator

commented Apr 8, 2015

Hey @chrissnell ,

Getting back around to this one, I think it looks good, however the Agent team has actually determined that this is one of those checks that should be enabled by default. See DataDog/dd-agent#1433 for more.

This should be making it into the 5.3.0 release in a few weeks, so I'm reluctant to add this to the mix right now - rather once 5.3.0 comes out, it's on by default for anyone.

How does that sound to you?

@miketheman

This comment has been minimized.

Copy link
Collaborator

commented Apr 9, 2015

Hi @chrissnell !
Sorry for any confusion, got this rebased and merged, along with a test. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.