Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@miketheman configurable process monitoring #190

Closed
wants to merge 5 commits into from

Conversation

Projects
None yet
2 participants
@jpcallanta
Copy link
Contributor

jpcallanta commented Mar 31, 2015

I've added process.rb recipe as well as the process.yaml.erb as discussed in the thread for pull request #124 and added test-kitchen test.


datadog_monitor 'process' do
instances node['datadog']['process']['instances']
end

This comment has been minimized.

Copy link
@miketheman

miketheman Mar 31, 2015

Collaborator

rubocop might yell at you for lacking a newline here

This comment has been minimized.

Copy link
@jpcallanta

jpcallanta Apr 1, 2015

Author Contributor

Ah, I'll fix

instances:
- name: "pidname"
exact_match: false
git a

This comment has been minimized.

Copy link
@miketheman

miketheman Mar 31, 2015

Collaborator

this might not be intended

@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Mar 31, 2015

Nice stuff. I might add a link in the "docs" section to see more over here: https://github.com/DataDog/dd-agent/blob/master/conf.d/process.yaml.example

miketheman added a commit that referenced this pull request Apr 2, 2015

Add process recipe and process template file for process monitoring
Includes serverspec test and kitchen config

Fixes #112
Closes #124, #181, #190

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Apr 2, 2015

Thanks! I rebased and cleaned up a bit for brevity, and merged in f048bbb

@miketheman miketheman closed this Apr 2, 2015

@miketheman miketheman added the feature label Apr 2, 2015

@miketheman miketheman added this to the Next minor milestone Apr 2, 2015

@miketheman miketheman self-assigned this Apr 2, 2015

miketheman added a commit that referenced this pull request Apr 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.