Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[elastic] Add config flags for shard level metrics #221

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@elafarge
Copy link
Contributor

commented Jul 29, 2015

Tested with test-kitchen.

@elafarge

This comment has been minimized.

Copy link
Contributor Author

commented Jul 29, 2015

WARNING: Since these changes will only be shipped with the 5.5 release of the Agent it might be better to wait for the release before merging that.

@miketheman

This comment has been minimized.

@miketheman miketheman added the feature label Aug 19, 2015

@miketheman miketheman added this to the Next minor milestone Aug 19, 2015

@elafarge elafarge force-pushed the etienne/add-new-es-flags branch from 8d918bd to a2f8033 Aug 19, 2015

@elafarge

This comment has been minimized.

Copy link
Contributor Author

commented Aug 19, 2015

Done @miketheman ! I squashed my changes with the previous commit (I'm not a big fan of Fixed typo or Added doc commit messages :) ).

@miketheman

This comment has been minimized.

Copy link
Collaborator

commented Aug 19, 2015

@elafarge Thanks! You might want to address the failures before we merge this.

Etienne LAFARGE

@elafarge elafarge force-pushed the etienne/add-new-es-flags branch from a2f8033 to 0da4fef Aug 20, 2015

@elafarge

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2015

Sorry about that @miketheman , I did this edit on a Windows machine where I didn't have my VIM hooks setup :/ We're finally green now :)

@miketheman miketheman deleted the etienne/add-new-es-flags branch Oct 15, 2015

@miketheman

This comment has been minimized.

Copy link
Collaborator

commented Oct 15, 2015

Thanks @elafarge !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.