Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix `updated_by_last_action` value of `monitor` provider #229
Replaces #168 (see discussion there for more context on this issue)
It makes the provider actions run in their own run context, so we need to redefine the
The behavior of the provider is preserved, except that the
@olivielpeau I'm not certain I follow. I think the desire is to have datadog-agent restart once, at the end of the run, if there are any services notifying it to do so - this appears to define extra resources with the same name (which causes the infamous resource cloning), and I'm not sure that's the correct behavior, since we can have multiple restarts per addition to the file.
I'm also not sure about the removal of the
@miketheman I agree that restarting the service multiple times per run is a big issue...
Given that the provider's actions are executed in their own run contexts, the only way that I see to notify the service in the main run context would be to remove the notifications in the provider and add:
I'm not sure what we could test exactly on the
We could definitely test the whole provider with chefspec though.