Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[why-run] Skip dd-handler recipe in why-run mode #231

Merged
merged 1 commit into from Oct 15, 2015

Conversation

Projects
None yet
2 participants
@olivielpeau
Copy link
Member

olivielpeau commented Sep 16, 2015

Running in why-run mode fails when the chef-handler-datadog gem is not
installed because of the require 'chef/handler/datadog' line, so we
skip the entire recipe in why-run mode.

Upgrading chef_handler to v1.2 (Chef>=12) will allow us to remove that
require and unskip the recipe in why-run mode.

See #118

[why-run] Skip dd-handler recipe in why-run mode
Running in why-run mode fails when the chef-handler-datadog gem is not
installed because of the `require 'chef/handler/datadog'` line, so we
skip the entire recipe in why-run mode.

Upgrading chef_handler to v1.2 (Chef>=12)  will allow us to remove that
`require` and unskip the recipe in why-run mode.

See #118

@olivielpeau olivielpeau added this to the Next minor milestone Sep 16, 2015

miketheman added a commit that referenced this pull request Oct 15, 2015

Merge pull request #231 from DataDog/olivielpeau/support-why-run
[why-run] Skip dd-handler recipe in why-run mode

@miketheman miketheman merged commit aba1adf into master Oct 15, 2015

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details

@miketheman miketheman deleted the olivielpeau/support-why-run branch Oct 15, 2015

@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Oct 15, 2015

Thanks @olivielpeau !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.