Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing options for rabbitmq collector #232

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@mattrobenolt
Copy link
Contributor

mattrobenolt commented Sep 17, 2015

Adds the following: nodes, nodes_regexes, queues, queues_regexes, and vhosts

@mattrobenolt mattrobenolt force-pushed the mattrobenolt:rabbitmq branch from 00e9070 to 63c80ea Sep 17, 2015

@@ -6,10 +6,40 @@ instances:
- rabbitmq_api_url: <%= i['api_url'] %>
rabbitmq_user: <%= i['user'] || 'guest' %>
rabbitmq_pass: <%= i['pass'] || 'guest' %>
tags:

This comment has been minimized.

Copy link
@mattrobenolt

mattrobenolt Sep 17, 2015

Author Contributor

This also makes tags get rendered out optionally since it doesn't make too much sense to render an empty tags key if none are passed. It's also an ambiguous data type in yaml. The correct form for an empty list would be: tags: [], which it wasn't doing anyways.

@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Oct 17, 2015

Hi @mattrobenolt!

Thanks for taking the time. We're trying to get into a model where the templates are simpler, and can be rendered from any Hash, allowing us to not have to update & release after any change in the Agent config.

This leads to simpler template code, and becomes a bit easier to maintain.

If you'd like to take the time to revisit this, we'd appreciate it!

@fhanson

This comment has been minimized.

Copy link

fhanson commented Apr 7, 2016

@miketheman is there a rewrite pending for converting to use any hash? If not this PR fixes a major problem for folks monitoring large rabbitmq setups.

@miketheman miketheman added this to the Next minor milestone Apr 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.