Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a datadog::consul recipe to monitor Consul #238

Merged
merged 3 commits into from Oct 15, 2015

Conversation

Projects
None yet
3 participants
@wk8
Copy link
Contributor

commented Sep 28, 2015

Thanks for adding Consul in dd-agent 5.5!

@darron darron self-assigned this Sep 29, 2015

@darron

This comment has been minimized.

Copy link
Contributor

commented Sep 29, 2015

👍

@miketheman Anything else we should add?

@wk8

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2015

@darron @miketheman : Had time to look over this? :)

@miketheman

This comment has been minimized.

Copy link
Collaborator

commented Oct 9, 2015

@wk8 I haven't had a chance yet - been out at a conference. Hope to come back to this soon. I'm also looking to establish quicker, simpler, ChefSpec spec tests for templates.

@wk8

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2015

Sounds good, thanks :-)

@miketheman miketheman added the feature label Oct 15, 2015

@miketheman miketheman added this to the Next minor milestone Oct 15, 2015

miketheman added a commit that referenced this pull request Oct 15, 2015

Merge pull request #238 from wk8/wk8/add_consul_recipe
Adding a datadog::consul recipe to monitor Consul

@miketheman miketheman merged commit 642458c into DataDog:master Oct 15, 2015

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 100.0%
Details
@miketheman

This comment has been minimized.

Copy link
Collaborator

commented Oct 15, 2015

Thanks @wk8 & @darron !

@wk8

This comment has been minimized.

Copy link
Contributor Author

commented Oct 15, 2015

Thank you!

@wk8 wk8 deleted the wk8:wk8/add_consul_recipe branch Oct 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.