Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This will add the sites config to the yaml file generated for iis #261

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@cobusbernard
Copy link
Contributor

cobusbernard commented Dec 7, 2015

This will add the 'sites' values to the generated iis.yaml for the DataDog agent on Windows. #260

@cobusbernard cobusbernard force-pushed the cobusbernard:master branch from 23a6a25 to 131f670 Dec 7, 2015

@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Mar 12, 2016

Hi @cobusbernard !

Thanks for the patches - I think the Marathon addition deserves its own PR.

Also, we don't accept patches containing modification to the version attribute in metadata.rb - please keep the patch to the code/tests/docs changes only.

@cobusbernard cobusbernard force-pushed the cobusbernard:master branch from f5b7469 to 43e3a34 Mar 14, 2016

@cobusbernard

This comment has been minimized.

Copy link
Contributor Author

cobusbernard commented Mar 14, 2016

@miketheman Done. Will create another PR for the Marathon part.

@cobusbernard

This comment has been minimized.

Copy link
Contributor Author

cobusbernard commented Apr 1, 2016

Hi @miketheman, stripped out the Marathon part as a separate PR and updated this PR as well.

@miketheman miketheman added this to the Next minor milestone Apr 21, 2016

miketheman added a commit that referenced this pull request Apr 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.