Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom metrics for postgres #284

Merged
merged 5 commits into from Aug 3, 2016

Conversation

Projects
None yet
4 participants
@flah00
Copy link
Contributor

flah00 commented Mar 16, 2016

  • Add support for custom metrics, in postgres integration
  • Add test for postgres integration
@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Apr 21, 2016

Hi @flah00 !
Would you consider porting the Kitchen test to a Spec test? See here for an example.

Specs are much "cheaper" to run overall, and validate template renderings just as much as the kitchen tests do. My hope is that we'll port over all existing kitchen tests to specs, and some of the effort has started, so I'd like to not introduce more if possible.

Rebase off master to ensure the specs run post-commit.

@flah00

This comment has been minimized.

Copy link
Contributor Author

flah00 commented Apr 29, 2016

sure thing, hopefully i can get to it next week

@olivielpeau

This comment has been minimized.

Copy link
Member

olivielpeau commented Jul 8, 2016

Thanks @flah00! We'll include this in the next minor release of the cookbook.

@olivielpeau olivielpeau added this to the 2.5.0 milestone Jul 8, 2016

@olivielpeau olivielpeau added ready and removed needs spec test labels Jul 8, 2016

@olivielpeau olivielpeau merged commit acfeb18 into DataDog:master Aug 3, 2016

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.