Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass 'tag_prefix' attribute to chef-handler-datadog #285

Closed

Conversation

Projects
None yet
2 participants
@mstepniowski
Copy link
Contributor

commented Mar 18, 2016

Allows users to specify custom tag prefix with tag_prefix default cookbook attribute. User can decide to send tags unprefixed by specifying tag_prefix = ''. Default prefix is still 'tag:'. Backwards compatibility is preserved.

Depends on DataDog/chef-handler-datadog#81

Pass 'tag_prefix' attribute to chef-handler-datadog
Allows users to specify custom tag prefix with tag_prefix default attribute. User can decide to send tags unprefixed by passing an optional tag_prefix = '' config value to chef-handler-datadog. Default prefix is still 'tag'. Backwards compatibility is preserved.

Depends on DataDog/chef-handler-datadog#81

@mstepniowski mstepniowski force-pushed the mstepniowski:marek/optional-tag-prefix branch from 1670db6 to a3ff222 Mar 18, 2016

Change the default tag_prefix to 'tag:'
This keeps the cookbook code in sync with chef-handler-datadog changes DataDog/chef-handler-datadog#81

@miketheman miketheman added the feature label Mar 21, 2016

@miketheman miketheman modified the milestone: Next minor Mar 21, 2016

@miketheman miketheman self-assigned this Apr 21, 2016

@miketheman

This comment has been minimized.

Copy link
Collaborator

commented Apr 21, 2016

@mstepniowski Heads up: In order to merge this cleanly, I had to remove the version bump in 45c26f0 from the master commit range until we release the next version (soon!).

If you depended on the version number to be updated during your cookbook deployment, I suggest you remain using your branch until the final version is deployed.

@miketheman

This comment has been minimized.

Copy link
Collaborator

commented Apr 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.