Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dns_check support #294

Merged
merged 1 commit into from May 4, 2016

Conversation

Projects
None yet
2 participants
@nickmarden
Copy link
Contributor

commented Apr 15, 2016

No description provided.

@nickmarden nickmarden force-pushed the RapidRiverSoftware:master branch from 5d011db to c2b4fbe Apr 18, 2016

@nickmarden

This comment has been minimized.

Copy link
Contributor Author

commented Apr 18, 2016

@miketheman Thanks for the needs spec test - I was unclear that individual recipes should be added for individual templates, but I followed my nose and came up with something that seems to have coverage and look like all of the other spec-ified recipes.

@miketheman

This comment has been minimized.

Copy link
Collaborator

commented May 2, 2016

Hi @nickmarden !
Thanks - the spec looks great, it's failing to run due to a linter violation - see https://travis-ci.org/DataDog/chef-datadog/builds/123973389#L254

@nickmarden nickmarden force-pushed the RapidRiverSoftware:master branch from c2b4fbe to 5c2c69c May 2, 2016

@nickmarden

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2016

Thanks @miketheman - fixed and re-running CI now.

@miketheman miketheman added ready and removed needs spec test labels May 2, 2016

@miketheman miketheman added this to the Next minor milestone May 2, 2016

@miketheman

This comment has been minimized.

Copy link
Collaborator

commented May 2, 2016

Thanks! Added to the merge queue.

@miketheman miketheman merged commit bb0f99c into DataDog:master May 4, 2016

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

miketheman added a commit that referenced this pull request May 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.