Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added recipe for go_expvar metrics collection #298

Merged

Conversation

Projects
None yet
3 participants
@hartfordfive
Copy link
Contributor

hartfordfive commented Apr 21, 2016

No description provided.

@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Apr 21, 2016

Hi @hartfordfive !

Can you please take a look at the approach for spec testing (vs kitchen) for integrations here: #295.

Also, we've adopted a very flexible method for templates, please follow this example: https://github.com/DataDog/chef-datadog/blob/4e59a32c7b692e8d4cf99bfb927af1de9e2c0118/templates/default/docker_daemon.yaml.erb

This leaves any further updates to the template to be attributes only, controlled by the end user, with no updates to the cookbook.

@hartfordfive

This comment has been minimized.

Copy link
Contributor Author

hartfordfive commented Apr 21, 2016

HI @miketheman, I'll make the necessary modifications and then push the updated code. Thanks.

@hartfordfive

This comment has been minimized.

Copy link
Contributor Author

hartfordfive commented Apr 21, 2016

@miketheman from what I can tell, the current CircleCI failure doesn't seem to be caused by anything in modifications, unless i'm missing something?

@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Apr 21, 2016

@hartfordfive I think it's because your branch is off the last release 2.2.0 - 4e59a32 instead of current master branch.

A rebase should solve it.

@miketheman miketheman added the feature label Apr 21, 2016

@miketheman miketheman merged commit 6c0d3e6 into DataDog:master Apr 21, 2016

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@miketheman miketheman added this to the Next minor milestone Apr 21, 2016

@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Apr 21, 2016

@hartfordfive Thanks! I squashed the commits and merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.