Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for tags #322

Merged
merged 3 commits into from Aug 3, 2016

Conversation

Projects
None yet
2 participants
@stensonb
Copy link
Contributor

stensonb commented Jul 7, 2016

No description provided.

@olivielpeau

This comment has been minimized.

Copy link
Member

olivielpeau commented Jul 8, 2016

Hi @stensonb, thanks for this addition.

Your change looks good, but could you add a spec test on the etcd recipe? (you can take https://github.com/DataDog/chef-datadog/blob/v2.4.0/spec/integrations/postgres_spec.rb as a reference)

If you don't have time let us know and we'll take care of it, thanks!

@stensonb

This comment has been minimized.

Copy link
Contributor Author

stensonb commented Jul 8, 2016

is spec/integrations where you want it, or should i modify the existing test/integration/datadog_etcd/serverspec/etcd_spec.rb

@olivielpeau

This comment has been minimized.

Copy link
Member

olivielpeau commented Jul 8, 2016

spec/integrations is where it should live, thanks :)

stensonb added some commits Jul 8, 2016

@stensonb

This comment has been minimized.

Copy link
Contributor Author

stensonb commented Jul 8, 2016

done! :)

@olivielpeau

This comment has been minimized.

Copy link
Member

olivielpeau commented Jul 12, 2016

Looks good, thanks!

We'll include this in the next minor release.

@olivielpeau olivielpeau added this to the 2.5.0 milestone Jul 12, 2016

@olivielpeau olivielpeau merged commit edd057f into DataDog:master Aug 3, 2016

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.