Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for iis wmi provider #324

Merged
merged 3 commits into from Aug 3, 2016

Conversation

Projects
None yet
2 participants
@clmoreno
Copy link
Contributor

clmoreno commented Jul 11, 2016

The new Datadog agent has been released and with it comes the solution for the issue #306

This pull request include the support to use this new feature adding "provider" to the IIS attributes declaration, as follows.

node.datadog.iis.instances = [ { "host" => "localhost", "provider" => '64', "tags" => ["tag1", "tag2"], "sites" => ["Default Web Site"] } ]

@olivielpeau

This comment has been minimized.

Copy link
Member

olivielpeau commented Jul 13, 2016

Hi @clmoreno and thanks for your contribution!

The tests are failing (see https://travis-ci.org/DataDog/chef-datadog/builds/144015476) because the provider is set in the yaml file even when the attribute is not defined.

Could you add an <% if i.key?('provider') -%> in the template so that the parameter is set in the yaml only when the attribute exists? Thanks!

@olivielpeau olivielpeau added the feature label Jul 13, 2016

@olivielpeau olivielpeau added this to the Triage milestone Jul 13, 2016

@clmoreno

This comment has been minimized.

Copy link
Contributor Author

clmoreno commented Jul 13, 2016

@olivielpeau fixed!

@olivielpeau

This comment has been minimized.

Copy link
Member

olivielpeau commented Jul 13, 2016

Looks good thanks! We'll include this in the next minor release

@olivielpeau olivielpeau modified the milestones: 2.5.0, Triage Jul 13, 2016

@olivielpeau olivielpeau added the ready label Jul 13, 2016

@olivielpeau olivielpeau merged commit 76c67d9 into DataDog:master Aug 3, 2016

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.