Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance remove-dd-agent.rb #332

Merged
merged 2 commits into from Aug 3, 2016

Conversation

Projects
None yet
2 participants
@raycrawford
Copy link
Contributor

commented Jul 22, 2016

Patch to fix or enhance remove-dd-agent.rb's functionality to include Windows. Tested on Windows 2012 R2 and Windows 2008 R2 SP1. In response to open issue 331 (#331).

Prior Linux-only code was included in case logic unchanged.

raycrawford added some commits Jul 22, 2016

Enhance remove-dd-agent.rb
Enhance to extend utility to include Windows.  Tested on Windows 2012 R2 and Windows 2008 R2 SP1.
@olivielpeau

This comment has been minimized.

Copy link
Member

commented Aug 2, 2016

Looks good, thanks @raycrawford!

@olivielpeau olivielpeau added this to the 2.5.0 milestone Aug 2, 2016

@olivielpeau olivielpeau merged commit 532c10b into DataDog:master Aug 3, 2016

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@olivielpeau

This comment has been minimized.

Copy link
Member

commented Aug 4, 2016

NB: on Windows, this appears to work only on Chef >= 12.6 (it uses the windows_package resource defined in core Chef, not the one in the windows cookbook)

I've added a note in 9628218 , we may want to investigate if we could extend it to Chef 12.x < 12.6 in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.