Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rebased] Update windows support to be much better #334

Merged
merged 1 commit into from Aug 5, 2016

Conversation

Projects
None yet
2 participants
@olivielpeau
Copy link
Member

olivielpeau commented Aug 3, 2016

Supersedes #252 (rebased version of that PR)

@olivielpeau olivielpeau added this to the 2.5.0 milestone Aug 3, 2016

@olivielpeau olivielpeau added the windows label Aug 3, 2016

@olivielpeau olivielpeau force-pushed the olivielpeau/windows-improvements-brentm5 branch 3 times, most recently from 6f170d4 to 6b74cc8 Aug 3, 2016

Update windows support to be much better
Things changed:
- Made the msi file install perMachine instead of per user
- Do not allow the program to restart the system
- Add checksum to verify file downloaded is who it says it is
- Removed chef 11.X from test kitchen for windows because its not
supported
- Update specs to change the resource name
- Add exception for legacy foodcritic warnings

[olivier.vielpeau@datadoghq.com: Add recommendation to use
`windows`<1.39.0 with Chef>=12.6]

@olivielpeau olivielpeau force-pushed the olivielpeau/windows-improvements-brentm5 branch from 6b74cc8 to 183b0b2 Aug 5, 2016

@olivielpeau olivielpeau merged commit 7f86286 into master Aug 5, 2016

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@olivielpeau olivielpeau deleted the olivielpeau/windows-improvements-brentm5 branch Aug 5, 2016

@olivielpeau olivielpeau added optimize and removed feature labels Aug 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.