Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moar chefspec testing #35

Merged
merged 3 commits into from Dec 26, 2012

Conversation

Projects
None yet
2 participants
@miketheman
Copy link
Collaborator

miketheman commented Dec 11, 2012

Attempts to start to cover all the "promises" we make in a recipe, which may diverge per platform, and verify that if the code changes, the promised behavior will not.

@clofresh

This comment has been minimized.

Copy link
Contributor

clofresh commented Dec 11, 2012

I get an error when I run rake spectest:

$ rake spectest
(in /Users/carlo/Projects/datadog/chef-datadog)
rake aborted!
/Users/carlo/Projects/datadog/chef-datadog/Rakefile:12: syntax error, unexpected ':', expecting kEND
    style.max_line_length 160, level: :warn
                                     ^
/Users/carlo/Projects/datadog/chef-datadog/Rakefile:19: syntax error, unexpected ':', expecting kEND
    style.max_line_length 160, level: :warn
                                     ^
/Users/carlo/Projects/datadog/chef-datadog/Rakefile:23: syntax error, unexpected ':', expecting kEND
    style.max_line_length 160, level: :warn
                                     ^

(See full trace by running task with --trace)
@miketheman

This comment has been minimized.

Copy link
Collaborator Author

miketheman commented Dec 11, 2012

@clofresh I suspect this might be a Ruby version problem. What version are you using?
Also, the command is rake chefspec vs rake spectest.

@clofresh

This comment has been minimized.

Copy link
Contributor

clofresh commented Dec 11, 2012

Ruby 1.8.7. Yeah it's erroring on any rake commands, even rake -T

@miketheman

This comment has been minimized.

Copy link
Collaborator Author

miketheman commented Dec 11, 2012

@clofresh Ought to work now, I added Ruby 1.8.7-style for the Rakefile syntax.
Note: Tests like foodcritic require Ruby 1.9.3.

Ruby 1.8.7 is scheduled for End Of Life as of June 2013 and is already in Maintenance-only mode.

@miketheman

This comment has been minimized.

Copy link
Collaborator Author

miketheman commented Dec 20, 2012

Any objections to merging this?

miketheman added a commit that referenced this pull request Dec 26, 2012

Merge pull request #35 from DataDog/spectest
Moar chefspec testing

@miketheman miketheman merged commit 9e1a1eb into master Dec 26, 2012

1 check passed

default The Travis build passed
Details

iancward added a commit to iancward/chef-datadog that referenced this pull request Oct 15, 2017

olivielpeau added a commit that referenced this pull request Nov 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.