Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #386 - Add recipe for windows_service integration #387

Merged
merged 5 commits into from Jan 4, 2017

Conversation

Projects
None yet
2 participants
@mlcooper
Copy link
Contributor

mlcooper commented Dec 21, 2016

No description provided.

@mlcooper

This comment has been minimized.

Copy link
Contributor Author

mlcooper commented Dec 21, 2016

@olivielpeau my PR, along with another one I noticed, is failing because of rubocop errors that are outside of the scope of this PR I'm submitting. How did the code that has rubocop errors get merged into master if it had rubocop errors? How shall I proceed? Thanks!

@olivielpeau

This comment has been minimized.

Copy link
Member

olivielpeau commented Jan 4, 2017

Thanks @mlcooper, this looks good! Merging

The test failures (unrelated to your changes as you noticed) have been addressed in #389

@olivielpeau olivielpeau added the feature label Jan 4, 2017

@olivielpeau olivielpeau added this to the 2.8.0 milestone Jan 4, 2017

@olivielpeau olivielpeau merged commit f6f923f into DataDog:master Jan 4, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.