Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attributes for package download retries options #390

Merged
merged 1 commit into from Jan 11, 2017

Conversation

Projects
None yet
2 participants
@degemer
Copy link
Member

degemer commented Jan 5, 2017

Allow users to specify the retries/retry_delay options of the package
resource with an attribute.

Fix #320

@degemer degemer requested a review from olivielpeau Jan 5, 2017

@degemer degemer force-pushed the quentin/implement-retries branch 4 times, most recently from 26ca6f6 to b0bfe45 Jan 5, 2017

@olivielpeau olivielpeau added this to the 2.8.0 milestone Jan 6, 2017

@olivielpeau
Copy link
Member

olivielpeau left a comment

👍

@@ -28,10 +28,15 @@
dd_agent_msi = dd_agent_version ? "ddagent-cli-#{dd_agent_version}.msi" : 'ddagent-cli.msi'
temp_file = ::File.join(Chef::Config[:file_cache_path], 'ddagent-cli.msi')

package_retries = node['datadog']['agent_package_retries']
package_retry_delay = node['agent_package_retry_delay']

This comment has been minimized.

Copy link
@olivielpeau

olivielpeau Jan 6, 2017

Member

Actually missed this: should be node['datadog']['agent_package_retry_delay']

Reminds me that I'd appreciate a few simple spec tests on this :)

Add attributes for package retries options
Allow users to specify the retries/retry_delay options of the package
resource on Linux, remote_file on Windows with an attribute.

@degemer degemer force-pushed the quentin/implement-retries branch from b0bfe45 to d40aefe Jan 9, 2017

@degemer degemer changed the title Add attributes for Linux package retries options Add attributes for package download retries options Jan 10, 2017

@degemer degemer merged commit 2a7e914 into master Jan 11, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@degemer degemer deleted the quentin/implement-retries branch Jan 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.