Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#401 - Allow configuration of Traces settings in datadog.conf #402

Merged
merged 8 commits into from Mar 7, 2017

Conversation

Projects
None yet
3 participants
@mlcooper
Copy link
Contributor

commented Feb 10, 2017

No description provided.

@talwai talwai self-assigned this Feb 17, 2017

default['datadog']['enable_trace_agent'] = false
default['datadog']['extra_sample_rate'] = 1
default['datadog']['max_traces_per_second'] = 10
default['datadog']['receiver_port'] = 7777

This comment has been minimized.

Copy link
@talwai

talwai Mar 3, 2017

we're actually deprecating 7777 for 8126 to be contiguous with statsd (though both work for the time being) . mind updating the default?

@talwai

This comment has been minimized.

Copy link

commented Mar 3, 2017

LGTM, aside from the comment - would be nice if @olivielpeau could take a glance as well

@olivielpeau
Copy link
Member

left a comment

@mlcooper: thanks! I've added a small comment on the attribute name, otherwise LGTM

default['datadog']['connection_limit'] = 2000

# ddtrace python version
default['datadog']['ddtrace_python_ver'] = nil

This comment has been minimized.

Copy link
@olivielpeau

olivielpeau Mar 7, 2017

Member

could you use a full ddtrace_python_version attribute name here? (just trying to be consistent with all the other occurences of *_version in the attributes names of the cookbook)

same thing for ddtrace_gem_version below

@olivielpeau
Copy link
Member

left a comment

Nice, thanks!

@olivielpeau olivielpeau added this to the 2.9.0 milestone Mar 7, 2017

@olivielpeau olivielpeau added the feature label Mar 7, 2017

@olivielpeau olivielpeau merged commit b5d9f56 into DataDog:master Mar 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

dsalvador-dsalvador added a commit to dsalvador-dsalvador/chef-datadog that referenced this pull request Mar 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.