Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Kubernetes recipe #409

Merged
merged 3 commits into from Mar 31, 2017

Conversation

Projects
None yet
2 participants
@xt99
Copy link
Contributor

commented Mar 1, 2017

Having this recipe in place one can easily monitor Kubernetes with DataDog using "the chef way"

@olivielpeau
Copy link
Member

left a comment

Thanks @xt99 for your contribution! The recipe looks good, but could you look into writing a spec test instead of an integration test (see my comment below).
Thanks again!

@@ -0,0 +1,33 @@
# Encoding: utf-8

This comment has been minimized.

Copy link
@olivielpeau

olivielpeau Mar 7, 2017

Member

instead of an integration test here, could you write a spec test? (you can take https://github.com/DataDog/chef-datadog/blob/v2.8.1/spec/integrations/docker_daemon_spec.rb as an example)

Spec tests are way lighter to run and can cover the integration recipes very well

@olivielpeau olivielpeau added this to the Triage milestone Mar 7, 2017

@xt99

This comment has been minimized.

Copy link
Contributor Author

commented Mar 9, 2017

Done:

$ rspec spec/integrations/kubernetes_spec.rb
..........

Finished in 2.66 seconds (files took 3.78 seconds to load)
10 examples, 0 failures

ChefSpec Coverage report generated...

  Total Resources:   7
  Touched Resources: 7
  Touch Coverage:    100.0%
@@ -394,6 +394,19 @@ suites:
my_consumer:
my_topic: [0, 1, 4, 12]

- name: datadog_kubernetes

This comment has been minimized.

Copy link
@olivielpeau

olivielpeau Mar 13, 2017

Member

actually could you remove the integration test and the related dir test/integration/datadog_kubernetes?

These tests are deprecated for integration recipes, we're just keeping the tests there until we move them all to spec tests.

Once you've removed them I'll merge, thanks 👍

@olivielpeau
Copy link
Member

left a comment

Perfect, thanks @xt99!

@olivielpeau olivielpeau modified the milestones: 2.10.0, Triage Mar 31, 2017

@olivielpeau olivielpeau merged commit a49ebbe into DataDog:master Mar 31, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.