Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attribute for custom gem server 2 #413

Conversation

Projects
None yet
2 participants
@dsalvador-dsalvador
Copy link
Contributor

dsalvador-dsalvador commented Mar 13, 2017

@olivielpeau Here's the new PR for custom gem server attribute.

@olivielpeau
Copy link
Member

olivielpeau left a comment

Thanks, just one comment on a typo, could you address it?

Other than that this looks ready 👍


# For custom gem servers on restricted networks
# This attribute only works on Chef >= 12.3
# Change flase to the URL of your custom gem server

This comment has been minimized.

Copy link
@olivielpeau

olivielpeau Mar 13, 2017

Member

typo: flase -> false :)

@olivielpeau

This comment has been minimized.

Copy link
Member

olivielpeau commented Mar 13, 2017

For reference this PR supersedes #407

@olivielpeau

This comment has been minimized.

Copy link
Member

olivielpeau commented Mar 13, 2017

Looks good, merging, thanks @dsalvador-dsalvador!

@olivielpeau olivielpeau added this to the 2.9.0 milestone Mar 13, 2017

@olivielpeau olivielpeau merged commit a4a7d78 into DataDog:master Mar 13, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.