Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set gpgcheck to true for yum_repository #458

Merged
merged 1 commit into from Sep 28, 2017

Conversation

Projects
None yet
2 participants
@dafyddcrosby
Copy link
Contributor

commented Jul 20, 2017

The yum_repository resource did not have gpgcheck true as the default until Chef 12.15

Explicitly set gpgcheck to true for yum_repository
The yum_repository resource did not have gpgcheck `true` as the default until Chef 12.15
@olivielpeau
Copy link
Member

left a comment

Good catch, thanks @dafyddcrosby!

For reference, if you're pulling version 3.x of the yum cookbook (which is a dep of the present cookbook), I believe the yum_repository resource should be provided by the yum cookbook instead of core Chef. And the yum cookbook enforces a default of true for gpgcheck, see https://github.com/chef-cookbooks/yum/blob/v3.0.0/resources/repository.rb#L34

Anyway, it makes sense to always enforce true here!

@olivielpeau olivielpeau added this to the 2.12.0 milestone Sep 28, 2017

@olivielpeau olivielpeau merged commit 32c8be8 into DataDog:master Sep 28, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.