Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #35 - Add recipe for go-metro integration #484

Merged
merged 4 commits into from Nov 30, 2017

Conversation

Projects
None yet
3 participants
@iancward
Copy link
Contributor

commented Oct 15, 2017

The recipe will:

  • handle installing the desired package for libcap
  • allow a user to override the package_name and any property of the libcap package resource
  • configure and deploy the go-metro yaml config

iancward added some commits Oct 15, 2017

Fixes for chefspec
- Rubocop fixes
- Actually test libcap_package attribute logic
@iancward

This comment has been minimized.

Copy link
Contributor Author

commented Nov 21, 2017

@olivielpeau any updates or feedback on this?

Thanks.

@olivielpeau
Copy link
Member

left a comment

Looks great, thanks @iancward! 👌

Merging this, will be part of 2.13.0

@olivielpeau olivielpeau added this to the 2.13.0 milestone Nov 30, 2017

@olivielpeau olivielpeau added the feature label Nov 30, 2017

@olivielpeau olivielpeau merged commit 736b884 into DataDog:master Nov 30, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rmoriz

This comment has been minimized.

Copy link

commented Jan 15, 2018

Using a dash "-" in the attribute name was a very poor decision, because even simple erb/template things explode e.g.:

template '/root/.dogrc' do
  source 'dogrc.erb'
  variables(
    node['datadog']
  )
  mode 0o600
end

template:


[Connection]
apikey: <%= @api_key %>
appkey: <%= @application_key %>

==>

    
    NameError
    ---------
    `@go-metro' is not allowed as an instance variable name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.