Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tokumx recipe, which about three people will use. #486

Merged
merged 2 commits into from Nov 30, 2017

Conversation

Projects
None yet
2 participants
@gswallow
Copy link
Contributor

commented Oct 17, 2017

No description provided.

@gswallow gswallow force-pushed the gswallow:add-tokumx branch from a523d95 to 31d467b Oct 17, 2017

Remove integration test
These tests aren't run in the CI, we should try to replace them
with rspec tests

@olivielpeau olivielpeau added this to the 2.13.0 milestone Nov 30, 2017

@olivielpeau
Copy link
Member

left a comment

Thanks @gswallow, you've made these 3 people happy 😄

I took the liberty to remove the integration test (since the integration-specific integration tests are not run in the CI, I'd like to replace them all with rspec tests), thanks for adding a spec test!

(I really should document that we're moving away from integration tests...)

@olivielpeau olivielpeau added the feature label Nov 30, 2017

@olivielpeau olivielpeau merged commit 87f5779 into DataDog:master Nov 30, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.