Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't print out an empty tags list for postgres #61

Merged
merged 4 commits into from Aug 16, 2013

Conversation

Projects
None yet
2 participants
@alq666
Copy link
Contributor

alq666 commented Jun 27, 2013

This, coupled with incorrect tag handling in the agent, caused the agent to crash whenever the postgres instance was used without tags.

If this is good to go, it'll be 1.0.2.

alq666 added some commits Jun 27, 2013

@ghost ghost assigned miketheman Jun 27, 2013

@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Jul 3, 2013

  1. Should we do this for every integration that can have optional tags?
  2. Please leave off the version-specific changes in the second commit - I have to commit a Changelog WIP I have for this, and metadata gets updated on release via knife-community
@alq666

This comment has been minimized.

Copy link
Contributor Author

alq666 commented Jul 3, 2013

I grepped the code and it was the only instance I found that had a missing if statement.

@alq666

This comment has been minimized.

Copy link
Contributor Author

alq666 commented Jul 3, 2013

Please merge at your convenience if this works for you.

miketheman added a commit that referenced this pull request Aug 16, 2013

Merge pull request #61 from DataDog/pg-none-tags
Don't print out an empty tags list for postgres

@miketheman miketheman merged commit 3a937cf into master Aug 16, 2013

1 check failed

default The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.