Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#62 Allow configuration of collect_connection_state, and excluded_interfaces in network.yaml #63

Merged
merged 3 commits into from Aug 20, 2013

Conversation

Projects
None yet
3 participants
@JoeDeVries
Copy link

commented Jul 2, 2013

No description provided.

@miketheman

This comment has been minimized.

Copy link
Collaborator

commented Jul 2, 2013

Hi @JoeDeVries,
Thanks, looks pretty good!

Can you add some logic to create the defaults if unspecified? Since this is a .yaml file that typically gets distributed with the Agent already enabled, I'd prefer not to overwrite any existing file without an operator intentionally doing that.

-M

@JoeDeVries

This comment has been minimized.

Copy link
Author

commented Jul 11, 2013

@miketheman Did my commit address your requirements?

@miketheman

This comment has been minimized.

Copy link
Collaborator

commented Jul 16, 2013

Hi @JoeDeVries,
I believe it did, we're a little behind on reviews and cookbook release process, but I'll try to get to this soon.

@miketheman miketheman merged commit 553dc76 into DataDog:master Aug 20, 2013

1 check failed

default The Travis CI build failed
Details

@ghost ghost assigned miketheman Aug 20, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.