Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #79 - use gsub to strip trailing character(s) #80

Closed
wants to merge 7 commits into from

Conversation

Projects
None yet
2 participants
@jtimberman
Copy link
Contributor

commented Nov 29, 2013

No description provided.

@ghost ghost assigned miketheman Nov 29, 2013

@miketheman

This comment has been minimized.

Copy link
Collaborator

commented Nov 29, 2013

Any chance you want to write a test case for this as well?
Something like: https://github.com/DataDog/chef-datadog/blob/master/spec/dd-agent_spec.rb#L55-L68

@miketheman

This comment has been minimized.

Copy link
Collaborator

commented Mar 19, 2014

@jtimberman I'm prepping to merge this, but there's some conflicts around Gemfile, .kitchen.yml and the spec file. I'll be cherry-picking around the things that make sense.

@miketheman

This comment has been minimized.

Copy link
Collaborator

commented Mar 19, 2014

Picks:

Updated the spec test for syntax in a0a1c11, added TK suite in b2ea22e.

Closing.

@miketheman miketheman closed this Mar 19, 2014

@jtimberman jtimberman deleted the jtimberman:python-version-debian branch Mar 22, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.