Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mongo recipe should install pymongo #81

Merged
merged 1 commit into from Mar 20, 2014

Conversation

Projects
None yet
2 participants
@dwradcliffe
Copy link
Contributor

dwradcliffe commented Dec 2, 2013

This also includes basic node attribute example.

@ghost ghost assigned miketheman Dec 5, 2013

@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Dec 5, 2013

Hi @dwradcliffe,

Thanks for the contribution! One open question:

Is the python-pymongo package name valid on both CentOS/Ubuntu? If not, can you add a platform-specific block, like this one?

@dwradcliffe

This comment has been minimized.

Copy link
Contributor Author

dwradcliffe commented Dec 5, 2013

Yep, I saw the same package name on both platforms.

@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Dec 5, 2013

I ran a search for Ubuntu, found it only on certain (recent?) versions:
http://packages.ubuntu.com/search?suite=all&arch=any&searchon=names&keywords=python-pymongo

Whereas on CentOS, it's not in the core, and requires EPEL, where the name differs:
http://dl.fedoraproject.org/pub/epel/6/x86_64/repoview/pymongo.html

Unless you have a different resource?

@dwradcliffe

This comment has been minimized.

Copy link
Contributor Author

dwradcliffe commented Jan 7, 2014

Ok, looks like the package only exists for Ubuntu 12.04 and later. Should I make the package conditional based on the Ubuntu version?

The yum EPEL package is under both names (http://dl.fedoraproject.org/pub/epel/6/x86_64/repoview/python-pymongo.html). Just pushed a fix for that.

@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Jan 7, 2014

@dwradcliffe I've been thinking about this one, and I think I'm going to prefer using a non-distro package, rather an easy_install one.

  1. distro packages commonly lag a lot behind the available code, sometimes missing performance and/or security patches
  2. There's inconsistency for availability among distros, and adding platform-specific code adds complexity to the cookbook.
  3. The yum cookbook recently went into a refactor, and yum::epel isn't there any more, and I'd rather not enforce a particular version of a dependency on users that might already be using a yum cookbook, and thereby break their usage.

Would you consider refactoring for a python package installation?

Thanks!

@dwradcliffe

This comment has been minimized.

Copy link
Contributor Author

dwradcliffe commented Jan 8, 2014

@miketheman Good points, especially the 3rd one.

Would package "python-setuptools" work cross-platform or is there a better way to ensure easy_install is available?

@dwradcliffe

This comment has been minimized.

Copy link
Contributor Author

dwradcliffe commented Jan 9, 2014

Seems to work for me on Ubuntu and CentOS. Latest code push includes a test-kitchen suite.

@miketheman miketheman added this to the Next minor milestone Mar 20, 2014

miketheman added a commit that referenced this pull request Mar 20, 2014

miketheman added a commit that referenced this pull request Mar 20, 2014

@miketheman miketheman merged commit 56a8bcd into DataDog:master Mar 20, 2014

1 check passed

default The Travis CI build passed
Details
@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Mar 20, 2014

Thanks @dwradcliffe ! Merged in, added some testing. Will go in next release!

@dwradcliffe dwradcliffe deleted the dwradcliffe:install-pymongo branch Mar 21, 2014

@dwradcliffe

This comment has been minimized.

Copy link
Contributor Author

dwradcliffe commented Mar 21, 2014

Awesome!

n1koo pushed a commit to Shopify/chef-datadog that referenced this pull request Oct 20, 2014

n1koo pushed a commit to Shopify/chef-datadog that referenced this pull request Oct 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.