Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not ignore attributes #88

Merged
merged 2 commits into from Mar 19, 2014

Conversation

Projects
None yet
2 participants
@flah00
Copy link
Contributor

commented Jan 16, 2014

The jmx.yaml.erb file has a small typo which causes it to ignore attributes. This fixes that issue. I didn't notice any tests for the jmx.yaml file...

I also realized that the structure of the yaml file doesn't appear to fully support both invocations of the attributes referenced here.

I was thinking it would be helpful if the attributes key could be an array or a hash. The array would be a list of strings, naming attributes. The hash would be a hash of hashes, the key would define the attribute, and the hash would define the metric type and alias. If that's agreeable, I could add that to this PR or make a separate one (and update the Vagrantfile).

@ghost ghost assigned miketheman Jan 17, 2014

@miketheman

This comment has been minimized.

Copy link
Collaborator

commented Jan 17, 2014

Hi @flah00 !
Thanks for the pull, sorry about that - we tried to validate a bunch of the generated templates during testing and this one must have gotten away.

I'm looking to work on this cookbook in February - is that cool?

@flah00

This comment has been minimized.

Copy link
Contributor Author

commented Jan 17, 2014

sounds good, i've got a modified local version i've uploaded to my chef repo in the meantime ... thanks

Fix white space
* @miketheman also pointed out that indentation was incorrect
@flah00

This comment has been minimized.

Copy link
Contributor Author

commented Mar 11, 2014

@miketheman miketheman merged commit e01f96a into DataDog:master Mar 19, 2014

1 check passed

default The Travis CI build passed
Details
@miketheman

This comment has been minimized.

Copy link
Collaborator

commented Mar 19, 2014

Thanks @flah00 - this will be in the next release!

miketheman added a commit that referenced this pull request Mar 19, 2014

n1koo pushed a commit to Shopify/chef-datadog that referenced this pull request Oct 20, 2014

miketheman added a commit that referenced this pull request Dec 30, 2014

Render jmx.yaml template based on data input
After multiple passes at attempting to cover all cases of inclusion of instance
details into a given YAML file, this lays the foundation for leaving the details
up to the end-user to implement the instance hash, instead of trying to capture
each possible flag.
This should help future-proof the recipe and template, so any new flags can be
appended as data.

See #88, #93 and fixes #116, #121.

Tests and examples updated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.