Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datadog::repository is not compatible withm yum 3.0.0 #89

Merged
merged 1 commit into from Mar 19, 2014

Conversation

Projects
None yet
2 participants
@alexism
Copy link
Contributor

commented Jan 27, 2014

The default value for gpgkey has changed in the yum cookbook 3.0.0. It is now set to true by default.

This will generate the following yum config:

[datadog]
name=datadog
baseurl=http://yum.datadoghq.com/rpm
enabled=1
gpgcheck=1
sslverify=1

With gpgcheck=1, datadog::repository fails with:
Package meld3-0.6.5-1.noarch.rpm is not signed

I opened a ticket and submitted a pull request to change the default value back to the previous behavior:

Another alternative would be to set gpgcheck to false in datadog::repository. See my commit in this pull-request.

Meanwhile a workaround is to rewind the yum_repository[datadog] resource by adding this in your recipe:

include_recipe 'datadog::dd-agent'

chef_gem 'chef-rewind'
require 'chef/rewind'

rewind 'yum_repository[datadog]' do
  gpgcheck false
end

@miketheman miketheman referenced this pull request Jan 27, 2014

Closed

Sign our RPMs #144

@ghost ghost assigned miketheman Jan 27, 2014

@miketheman

This comment has been minimized.

Copy link
Collaborator

commented Jan 27, 2014

Hi @alexism!

Thanks for the code. I saw that the maintainer of the yum cookbook denied the code change, which isn't wonderful, but thanks for taking the time to do it.

I hope to get to this next week!

@alexism

This comment has been minimized.

Copy link
Contributor Author

commented Jan 27, 2014

my pleasure.

At least we have a workaround meanwhile.

@miketheman miketheman merged commit 2d7d3ab into DataDog:master Mar 19, 2014

1 check passed

default The Travis CI build passed
Details

n1koo pushed a commit to Shopify/chef-datadog that referenced this pull request Oct 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.