Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add defaults for dogstatsd #90

Merged
merged 1 commit into from Mar 20, 2014

Conversation

Projects
None yet
3 participants
@jedi4ever
Copy link
Contributor

jedi4ever commented Jan 27, 2014

enabling dogstatsd is not enough, as this will create an empty port & interval variable.
Therefore we add it to the default attributes

@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Jan 27, 2014

@jedi4ever That's very odd - we added that in da54faa - but that seems to be gone. Will have to dig for what happened.

@ghost ghost assigned miketheman Jan 27, 2014

@zshenker

This comment has been minimized.

Copy link
Contributor

zshenker commented Mar 5, 2014

Any follow up on this? The current master does not contain these attributes.

It looks like it was removed in commit, f2422bb

@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Mar 19, 2014

@jedi4ever Thanks for this - I am curious, why is the default false? Was that a safeguard against what was seemingly not there? We had this previously enabled and we lost it in the shuffle as @zshenker pointed out.
I'm happy to flip the bit to true and merge, unless there's some other reasoning?

@jedi4ever

This comment has been minimized.

Copy link
Contributor Author

jedi4ever commented Mar 20, 2014

There are two reasons:

  • datadog statsd isn't enabled by default, therefore I put false
  • and I guess it makes sense that this is off by default, I would not a tcp listener if I haven't specifically enabled it.
@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Mar 20, 2014

Hi @jedi4ever,
I tested it this morning, and without the config there, the default is to start the dogstatsd listener, bound only to 127.0.0.1.

So it defaults to true when not there, and starts up bound to localhost. I'm going to merge this in, and flip it to true.

Thanks!

@miketheman miketheman merged commit fdfed9a into DataDog:master Mar 20, 2014

1 check passed

default The Travis CI build passed
Details

miketheman added a commit that referenced this pull request Mar 20, 2014

miketheman added a commit that referenced this pull request Mar 20, 2014

n1koo pushed a commit to Shopify/chef-datadog that referenced this pull request Oct 20, 2014

n1koo pushed a commit to Shopify/chef-datadog that referenced this pull request Oct 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.