Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce chef_handler_enable to control the chef reporting #95

Merged
merged 1 commit into from Mar 20, 2014

Conversation

Projects
None yet
3 participants
@jedi4ever
Copy link
Contributor

jedi4ever commented Jan 30, 2014

Controlling the agent stop and start is not enough to prevent data to be send from a host to datadog.
The chef handler reports directly via the gem, so we need another flag : node[:datadog][:chef_handler_enable]

@evan2645

This comment has been minimized.

Copy link
Contributor

evan2645 commented Jan 30, 2014

What about something like

include_recipe 'datadog::dd-handler' if node['datadog']['chef_handler_enable']

in datadog::dd-agent?

@jedi4ever

This comment has been minimized.

Copy link
Contributor Author

jedi4ever commented Jan 30, 2014

because I'd like to have the installation of the gem already done , just enable/disable the handler reporting

@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Jan 30, 2014

@jedi4ever I don't know if I like wrapping the entire resource in an if really much - can it be passed along as an only_if to the resource, during compile phase?

@miketheman miketheman added this to the Next minor milestone Mar 19, 2014

miketheman added a commit that referenced this pull request Mar 20, 2014

move resource conditional to not wrap resource
rather follow it, for readability. Refs #95

@miketheman miketheman merged commit cb60d13 into DataDog:master Mar 20, 2014

1 check passed

default The Travis CI build passed
Details
@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Mar 20, 2014

Thanks @jedi4ever ! I added a commit to style the resource here: 3e23489 - better view: 3e23489?w=1

miketheman added a commit that referenced this pull request Mar 20, 2014

n1koo pushed a commit to Shopify/chef-datadog that referenced this pull request Oct 20, 2014

move resource conditional to not wrap resource
rather follow it, for readability. Refs DataDog#95

n1koo pushed a commit to Shopify/chef-datadog that referenced this pull request Oct 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.