Fix test setup (gem deps install) #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes rubygems and bundler slightly smarter in terms of installing gems that are compatible with the version of ruby
| before_install: | ||
| - gem update --system | ||
| - gem --version | ||
| - gem install bundler --pre |
There was a problem hiding this comment.
I'm not a huge fan of these, but it's only for tests, and I don't see rubygems and/or bundler having a bad release without releasing immediately a fix.
|
LGTM |
|
Thanks @degemer for the review! Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before_installstep: This makes rubygems and bundler slightly smarter in terms of installing gems that are compatible with the version of rubyjsonandrackversion constraints for chef 11 (unfortunately1.is not enough for thechef-11tests apparently...)