Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker CPU shares gauge #1597

Merged
merged 3 commits into from Apr 23, 2018

Conversation

Projects
None yet
3 participants
@hkaj
Copy link
Member

hkaj commented Apr 16, 2018

What does this PR do?

Add docker CPU shares gauge

Motivation

Additional Notes

Anything else we should know when reviewing?

@hkaj hkaj added this to the 6.2.0 milestone Apr 16, 2018

@hkaj hkaj requested review from DataDog/burrito as code owners Apr 16, 2018

if err == nil {
ret.Shares = shares
} else {
log.Debugf("missing cpu shares stat for %s: %s", c.ContainerID, err.Error())

This comment has been minimized.

@mfpierre

mfpierre Apr 16, 2018

Contributor

s/missing/Missing

@xvello

xvello approved these changes Apr 20, 2018

Copy link
Member

xvello left a comment

LGTM

@hkaj hkaj merged commit 8607baa into master Apr 23, 2018

10 checks passed

ci/circleci: build_binaries Your tests passed on CircleCI!
Details
ci/circleci: build_puppy Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: dependencies Your tests passed on CircleCI!
Details
ci/circleci: docker_integration_tests Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: reno_linting Your tests passed on CircleCI!
Details
ci/circleci: unit_tests Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@hkaj hkaj deleted the haissam/docker-cpu-shares branch Apr 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.