[workloadmeta] componentize logic #19707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliDatadog
reviewed
Sep 25, 2023
truthbk
force-pushed
the
jaime/workloadmeta
branch
2 times, most recently
from
56f225f
to
f8bbcef
Compare
truthbk
force-pushed
the
jaime/workloadmeta
branch
from
8a285eb
to
efc5a4c
Compare
truthbk
force-pushed
the
jaime/workloadmeta
branch
4 times, most recently
from
9f22c9a
to
cfad53f
Compare
truthbk
force-pushed
the
jaime/workloadmeta
branch
11 times, most recently
from
4d838a3
to
50c450c
Compare
truthbk
force-pushed
the
jaime/workloadmeta
branch
from
f5cd32a
to
3121e52
Compare
[workloadmeta] fix lint
truthbk
force-pushed
the
jaime/workloadmeta
branch
from
ab81d7a
to
d3255d7
Compare
zhuminyi
approved these changes
Nov 17, 2023
truthbk
force-pushed
the
jaime/workloadmeta
branch
from
34d6317
to
b4f98d6
Compare
ogaca-dd
approved these changes
Nov 20, 2023
| } else { | ||
| catalog = workloadmeta.NodeAgent | ||
| } | ||
| catalog := workloadmeta.NodeAgent |
There was a problem hiding this comment.
Is it expected catalog is never set to workloadmeta.ClusterAgent?
There was a problem hiding this comment.
Yes, for dogstatsd I think this is expected.
| components := &DogstatsdComponents{ | ||
| DogstatsdServer: server, | ||
| WorkloadMeta: wmeta, | ||
| WorkloadMeta: w, |
There was a problem hiding this comment.
Ideally WorkloadMeta type could be optional.Option[workloadmeta.Component].
There was a problem hiding this comment.
To avoid running the CI again and hold back the train after the freeze, I'll do this in a follow-up. But that makes sense, I can make that change.
10 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves
pkg/workloadmetatocomp/core/workloadmeta.Motivation
Componentize workloadmeta as a pre-requisite for the
taggerandauto-discoverycomponents.Additional Notes
Still some global state that should be eventually addressed.
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
Triagemilestone is set.major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changeloglabel has been applied.qa/skip-qalabel is not applied.team/..label has been applied, indicating the team(s) that should QA this change.need-change/operatorandneed-change/helmlabels have been applied.k8s/<min-version>label, indicating the lowest Kubernetes version compatible with this feature.