[internal/tools] bump golangci-lint to v1.54.2 #19752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pducolin
added
changelog/no-changelog
team/agent-platform
qa/skip-qa [deprecated]
pducolin
commented
Sep 26, 2023
| github.com/goware/modvendor v0.5.0 | ||
| github.com/mgechev/revive v1.2.5 | ||
| github.com/mgechev/revive v1.3.2 |
There was a problem hiding this comment.
Note for reviewers: revive bumped while bumping golangci-lint
pducolin
commented
Sep 27, 2023
| github.com/Masterminds/semver v1.5.0 // indirect | ||
| github.com/Microsoft/go-winio v0.6.1 // indirect | ||
| github.com/OpenPeeDeeP/depguard v1.1.1 // indirect | ||
| github.com/OpenPeeDeeP/depguard/v2 v2.1.0 // indirect |
There was a problem hiding this comment.
note for reviewers: this is why I had to update the depguard config 😢
pducolin
force-pushed
the
pducolin/APL-2071-bump-golangcilint
branch
from
3564e24
to
1c8b60a
Compare
pducolin
force-pushed
the
pducolin/APL-2071-bump-golangcilint
branch
5 times, most recently
from
a01296d
to
105cbf7
Compare
coignetp
approved these changes
Oct 13, 2023
paulcacheux
approved these changes
Oct 13, 2023
AlexandreYang
approved these changes
Oct 13, 2023
clamoriniere
approved these changes
Oct 13, 2023
pkg/clusteragent/admission/controllers/webhook/controller_v1_test.go
Outdated
Show resolved
Hide resolved
pkg/collector/corechecks/containers/containerd/containerd_transformers.go
Outdated
Show resolved
Hide resolved
mfpierre
approved these changes
Oct 13, 2023
pducolin
commented
Oct 13, 2023
NouhaManai96
approved these changes
Oct 13, 2023
robertjli
approved these changes
Oct 13, 2023
spencergilbert
approved these changes
Oct 13, 2023
richl-dd
approved these changes
Oct 13, 2023
jmeunier28
approved these changes
Oct 13, 2023
guyarb
approved these changes
Oct 13, 2023
derekwbrown
approved these changes
Oct 13, 2023
purple4reina
approved these changes
Oct 13, 2023
remeh
approved these changes
Oct 16, 2023
vboulineau
approved these changes
Oct 16, 2023
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bump golangci-lint to v1.54.2
Motivation
Bump dependency and run on latest stable golangci-lint version
Additional Notes
For teams: new linter errors on current code are muted inline with the format
//nolint:[linter name] // TODO fix [linter name] [rule name]It is up to the team to fix these errors. The agent platform team will use this new process from now on, as any golangci-lint bump will raise new errors we don't want to keep updating the reference commit
new-from-rev.We are working on adding a job that is allowed to fail and that runs linters removing these
//nolint:[] // TODO [][]to keep track of legacy issues.Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Reviewer's Checklist
Triagemilestone is set.major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changeloglabel has been applied.qa/skip-qalabel is not applied.team/..label has been applied, indicating the team(s) that should QA this change.need-change/operatorandneed-change/helmlabels have been applied.k8s/<min-version>label, indicating the lowest Kubernetes version compatible with this feature.