Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Modules in pkg/util #19902

Merged
merged 9 commits into from Oct 10, 2023
Merged

Create Modules in pkg/util #19902

merged 9 commits into from Oct 10, 2023

Conversation

dineshg13
Copy link
Member

@dineshg13 dineshg13 commented Oct 3, 2023

What does this PR do?

Following the RFC, I converted the serializer into a go module in my experimental PR. https://github.com/DataDog/datadog-agent/pull/18712/files . We are starting to create smaller reviewable PRs that we can merge. This PR creates modules some of the packages of pkg/util by moving them to pkg/util/module.

Motivation

We need to create almost 14 modules of sub-packages of pkg/util. Instead of many modules, we made one go module, pkg/util/module and moved packages there.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@dineshg13 dineshg13 changed the title Create pkg/util/module package Create package and module pkg/util/module Oct 3, 2023
@dineshg13 dineshg13 marked this pull request as ready for review October 3, 2023 14:47
@dineshg13 dineshg13 requested review from a team as code owners October 3, 2023 14:47
@dineshg13 dineshg13 requested a review from mx-psi October 3, 2023 14:47
@dineshg13 dineshg13 removed request for a team October 4, 2023 13:06
@dineshg13 dineshg13 requested review from pgimalac and a team and removed request for a team October 4, 2023 13:08
Copy link
Contributor

@pgimalac pgimalac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the changes !

go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@dineshg13 dineshg13 added the team/opentelemetry OpenTelemetry team label Oct 10, 2023
@dineshg13 dineshg13 modified the milestones: 7.50.0, 7.48.0, 7.49.0 Oct 10, 2023
@dineshg13 dineshg13 merged commit 3ba47bf into main Oct 10, 2023
133 checks passed
@dineshg13 dineshg13 deleted the dinesh.gurumurthy/OTEL-955 branch October 10, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants