[ASCII-1024] Render agent gui status using status component #22287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GustavoCaso
force-pushed
the
render-agent-gui-status-using-status-component
branch
from
d58aca1
to
70a7c58
Compare
Base automatically changed from
render-agent-status-using-status-component
to
main
January 25, 2024 17:26
|
Due to an issue merging the main back into this stacked PR, I carried over all the previous commits from #22115. That causes GH to assign new reviewers, but the actual file owners of the files modified on this PR already give the 👍. I will remove the ones added by GH because of the issue. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| w.Header().Set("Content-Type", "text/html") | ||
| w.Write([]byte(html)) | ||
| w.Write(stats) |
Check warning
Code scanning / CodeQL
Reflected cross-site scripting Medium
|
/merge |
|
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 47m) Use |
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-mergequeue
bot
deleted the
render-agent-gui-status-using-status-component
branch
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
You can use the previous work done in #22115 and modify the GUI to use the status component for fetching and rendering the information.
With the help of the status component we no longer have to maintain the general and collector templates in the
cmd/agent/gui/views/templatesfolder.Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
PLEASE TAKE INTO CONSIDERATION THAT THE ORDER OF THE STATUS OUTPUT HAS CHANGED. When doing the QA, we need to focus on the same information being displayed and not too much on order.
Build the agent binary
invoke agent.build --build-exclude=systemdTest that the agent status information gets appropriately displayed in the GUI
agent launch-guiMake sure to click in the general status and the collector tab to validate all information is being render properly
Reviewer's Checklist
Triagemilestone is set.major_changelabel if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changeloglabel has been applied.qa/skip-qalabel, with required eitherqa/doneorqa/no-code-changelabels, are applied.team/..label has been applied, indicating the team(s) that should QA this change.need-change/operatorandneed-change/helmlabels have been applied.k8s/<min-version>label, indicating the lowest Kubernetes version compatible with this feature.