Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tasks: add cross-compile task to trace-agent #3100

Merged
merged 2 commits into from Mar 1, 2019
Merged

Conversation

gbbr
Copy link
Contributor

@gbbr gbbr commented Feb 27, 2019

This change adds the invoke trace-agent.cross-compile task simplifying
cross-compilation of the trace-agent binaries for releases. Example:

$ inv trace-agent.cross-compile --tag=6.10.0 # builds tag 6.10.0

It also removes unnecessary entries in the Makefile.trace file and updates
documentation.

@gbbr gbbr added this to the 6.11.0 milestone Feb 27, 2019
@gbbr gbbr requested a review from a team as a code owner February 27, 2019 14:09
@gbbr gbbr force-pushed the gbbr/cross-compile-task branch 2 times, most recently from 821cd91 to 2d1f5ce Compare February 27, 2019 14:12
@gbbr gbbr changed the title tasks: add cross-compile task tasks: add cross-compile task to trace-agent Feb 27, 2019
@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #3100 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3100   +/-   ##
=======================================
  Coverage   54.19%   54.19%           
=======================================
  Files         540      540           
  Lines       38333    38333           
=======================================
  Hits        20773    20773           
  Misses      16324    16324           
  Partials     1236     1236
Flag Coverage Δ
#linux 57.18% <ø> (-0.03%) ⬇️
#windows 56.04% <ø> (+0.01%) ⬆️
Impacted Files Coverage Δ
pkg/forwarder/worker.go 91.25% <0%> (-2.5%) ⬇️
pkg/trace/writer/stats.go 90.76% <0%> (+1.02%) ⬆️

tasks/trace_agent.py Outdated Show resolved Hide resolved
tasks/trace_agent.py Outdated Show resolved Hide resolved
tasks/trace_agent.py Outdated Show resolved Hide resolved
Copy link
Contributor Author

@gbbr gbbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Addressed.

tasks/trace_agent.py Outdated Show resolved Hide resolved
tasks/trace_agent.py Outdated Show resolved Hide resolved
@gbbr gbbr requested a review from jdgumz February 27, 2019 14:34
This change adds the invoke trace-agent.cross-compile task simplifying
cross-compilation of the trace-agent binaries for releases. Example:

    $ inv trace-agent.cross-compile --tag=6.10.0 # builds tag 6.10.0

It also removes unnecessary entries in the Makefile.trace file and updates
documentation.
@DataDog DataDog deleted a comment from jdgumz Feb 27, 2019
@DataDog DataDog deleted a comment from jdgumz Feb 27, 2019
@gbbr
Copy link
Contributor Author

gbbr commented Feb 27, 2019

@jdgumz I accidentally deleted your comment about the extra $(V) env. var. Sorry about that 😞

jdgumz
jdgumz previously approved these changes Feb 27, 2019
Copy link
Contributor

@jdgumz jdgumz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gbbr no worries about the comment deletion - up to you if you want to use $V to make the command strings shorter.

AlexJF
AlexJF previously approved these changes Feb 28, 2019
tasks/trace_agent.py Outdated Show resolved Hide resolved
@gbbr gbbr dismissed stale reviews from AlexJF and jdgumz via 22ad52c February 28, 2019 14:00
@gbbr gbbr merged commit e8adc0e into master Mar 1, 2019
@gbbr gbbr deleted the gbbr/cross-compile-task branch March 1, 2019 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants