New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tasks: add cross-compile task to trace-agent #3100
Conversation
821cd91
to
2d1f5ce
Compare
Codecov Report
@@ Coverage Diff @@
## master #3100 +/- ##
=======================================
Coverage 54.19% 54.19%
=======================================
Files 540 540
Lines 38333 38333
=======================================
Hits 20773 20773
Misses 16324 16324
Partials 1236 1236
|
2d1f5ce
to
7aca78c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Addressed.
This change adds the invoke trace-agent.cross-compile task simplifying cross-compilation of the trace-agent binaries for releases. Example: $ inv trace-agent.cross-compile --tag=6.10.0 # builds tag 6.10.0 It also removes unnecessary entries in the Makefile.trace file and updates documentation.
7aca78c
to
fa158be
Compare
@jdgumz I accidentally deleted your comment about the extra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gbbr no worries about the comment deletion - up to you if you want to use $V
to make the command strings shorter.
This change adds the invoke trace-agent.cross-compile task simplifying
cross-compilation of the trace-agent binaries for releases. Example:
$ inv trace-agent.cross-compile --tag=6.10.0 # builds tag 6.10.0
It also removes unnecessary entries in the Makefile.trace file and updates
documentation.