Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docker Check] add kernel memory usage metric #3396

Merged
merged 1 commit into from May 3, 2019

Conversation

Projects
None yet
3 participants
@wolf31o2
Copy link
Contributor

commented May 1, 2019

What does this PR do?

Extends Docker check to provide Kernel Memory Usage Metric

Containers run under cgroups with kernel memory accounting enabled will consume kernel memory which needs to be tracked.

Motivation

Running Docker under CentOS 7 and hitting issues described in runc and Mesosphere DC/OS

Additional Notes

This metric will be zero under newer Docker (18.09) and CentOS 7 kernels. Running containers will memory limits (not kernel memory limits) under CentOS 7 with Docker 17.06 will account usage. Modern Docker on a modern kernel requires setting kernel memory limits when starting the container for this metric to take effect.

This is the Agent 6 implementation of DataDog/integrations-core#3339

@wolf31o2 wolf31o2 requested a review from DataDog/container-integrations as a code owner May 1, 2019

@bits-bot

This comment has been minimized.

Copy link
Collaborator

commented May 1, 2019

CLA assistant check
All committers have signed the CLA.

@hkaj hkaj added this to the 6.12.0 milestone May 2, 2019

[Docker Check] add kernel memory usage metric
Signed-off-by: Chris Gianelloni <wolf31o2@gmail.com>

@wolf31o2 wolf31o2 force-pushed the wolf31o2:docker-kmem branch from 388bc94 to 24427da May 3, 2019

@wolf31o2

This comment has been minimized.

Copy link
Contributor Author

commented May 3, 2019

@hkaj can I get a review when you have time? I've addressed your comments.

@hkaj

hkaj approved these changes May 3, 2019

Copy link
Member

left a comment

@hkaj

This comment has been minimized.

Copy link
Member

commented May 3, 2019

thanks @wolf31o2 🎉

@hkaj hkaj merged commit 68b5802 into DataDog:master May 3, 2019

12 of 13 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
ci/circleci: build_binaries Your tests passed on CircleCI!
Details
ci/circleci: build_puppy Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: dependencies Your tests passed on CircleCI!
Details
ci/circleci: docker_tests Your tests passed on CircleCI!
Details
ci/circleci: filename_linting Your tests passed on CircleCI!
Details
ci/circleci: integration_tests Your tests passed on CircleCI!
Details
ci/circleci: milestone Your tests passed on CircleCI!
Details
ci/circleci: release_note Your tests passed on CircleCI!
Details
ci/circleci: team_label Your tests passed on CircleCI!
Details
ci/circleci: unit_tests Your tests passed on CircleCI!
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.