Skip to content

[MA-1666][slo correction]update required fields in create and update requests #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2021
Merged

[MA-1666][slo correction]update required fields in create and update requests #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .apigentools-info
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
"spec_versions": {
"v1": {
"apigentools_version": "1.4.1.dev2",
"regenerated": "2021-01-21 15:40:42.539030",
"spec_repo_commit": "a46429c"
"regenerated": "2021-01-22 07:54:16.914450",
"spec_repo_commit": "e264b45"
},
"v2": {
"apigentools_version": "1.4.1.dev2",
"regenerated": "2021-01-21 15:40:55.269247",
"spec_repo_commit": "a46429c"
"regenerated": "2021-01-22 07:54:28.907555",
"spec_repo_commit": "e264b45"
}
}
}
15 changes: 6 additions & 9 deletions data/v1/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4842,15 +4842,15 @@ components:
format: int64
type: integer
timezone:
description: Timezone of the timestamps provided
description: The timezone to display in the UI for the correction times
(defaults to "UTC")
example: UTC
type: string
required:
- slo_id
- start
- end
- category
- timezone
type: object
SLOCorrectionListResponse:
description: A list of SLO correction objects
Expand Down Expand Up @@ -4910,7 +4910,8 @@ components:
format: int64
type: integer
timezone:
description: Timezone of the timestamps provided
description: The timezone to display in the UI for the correction times
(defaults to "UTC")
type: string
type: object
SLOCorrectionUpdateRequest:
Expand Down Expand Up @@ -4946,14 +4947,10 @@ components:
format: int64
type: integer
timezone:
description: Timezone of the timestamps provided
description: The timezone to display in the UI for the correction times
(defaults to "UTC")
example: UTC
type: string
required:
- start
- end
- category
- timezone
type: object
SLODeleteResponse:
description: A response list of all service level objective deleted.
Expand Down
2 changes: 1 addition & 1 deletion docs/v1/SLOCorrectionCreateRequestAttributes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
| **_end** | **Integer** | Ending time of the correction in epoch seconds | |
| **slo_id** | **String** | ID of the SLO that this correction will be applied to | |
| **start** | **Integer** | Starting time of the correction in epoch seconds | |
| **timezone** | **String** | Timezone of the timestamps provided | |
| **timezone** | **String** | The timezone to display in the UI for the correction times (defaults to \"UTC\") | [optional] |

## Example

Expand Down
2 changes: 1 addition & 1 deletion docs/v1/SLOCorrectionResponseAttributes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
| **_end** | **Integer** | Ending time of the correction in epoch seconds | [optional] |
| **slo_id** | **String** | ID of the SLO that this correction will be applied to | [optional] |
| **start** | **Integer** | Starting time of the correction in epoch seconds | [optional] |
| **timezone** | **String** | Timezone of the timestamps provided | [optional] |
| **timezone** | **String** | The timezone to display in the UI for the correction times (defaults to \"UTC\") | [optional] |

## Example

Expand Down
8 changes: 4 additions & 4 deletions docs/v1/SLOCorrectionUpdateRequestAttributes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@

| Name | Type | Description | Notes |
| ---- | ---- | ----------- | ----- |
| **category** | [**SLOCorrectionCategory**](SLOCorrectionCategory.md) | | |
| **category** | [**SLOCorrectionCategory**](SLOCorrectionCategory.md) | | [optional] |
| **description** | **String** | Description of the correction being made. | [optional] |
| **_end** | **Integer** | Ending time of the correction in epoch seconds | |
| **start** | **Integer** | Starting time of the correction in epoch seconds | |
| **timezone** | **String** | Timezone of the timestamps provided | |
| **_end** | **Integer** | Ending time of the correction in epoch seconds | [optional] |
| **start** | **Integer** | Starting time of the correction in epoch seconds | [optional] |
| **timezone** | **String** | The timezone to display in the UI for the correction times (defaults to \"UTC\") | [optional] |

## Example

Expand Down
7 changes: 1 addition & 6 deletions lib/datadog_api_client/v1/models/slo_correction_create_request_attributes.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class SLOCorrectionCreateRequestAttributes
# Starting time of the correction in epoch seconds
attr_accessor :start

# Timezone of the timestamps provided
# The timezone to display in the UI for the correction times (defaults to \"UTC\")
attr_accessor :timezone

# Attribute mapping from ruby-style variable name to JSON key.
Expand Down Expand Up @@ -131,10 +131,6 @@ def list_invalid_properties
invalid_properties.push('invalid value for "start", start cannot be nil.')
end

if @timezone.nil?
invalid_properties.push('invalid value for "timezone", timezone cannot be nil.')
end

invalid_properties
end

Expand All @@ -145,7 +141,6 @@ def valid?
return false if @_end.nil?
return false if @slo_id.nil?
return false if @start.nil?
return false if @timezone.nil?
true
end

Expand Down
2 changes: 1 addition & 1 deletion lib/datadog_api_client/v1/models/slo_correction_response_attributes.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class SLOCorrectionResponseAttributes
# Starting time of the correction in epoch seconds
attr_accessor :start

# Timezone of the timestamps provided
# The timezone to display in the UI for the correction times (defaults to \"UTC\")
attr_accessor :timezone

# Attribute mapping from ruby-style variable name to JSON key.
Expand Down
22 changes: 1 addition & 21 deletions lib/datadog_api_client/v1/models/slo_correction_update_request_attributes.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class SLOCorrectionUpdateRequestAttributes
# Starting time of the correction in epoch seconds
attr_accessor :start

# Timezone of the timestamps provided
# The timezone to display in the UI for the correction times (defaults to \"UTC\")
attr_accessor :timezone

# Attribute mapping from ruby-style variable name to JSON key.
Expand Down Expand Up @@ -106,32 +106,12 @@ def initialize(attributes = {})
# @return Array for valid properties with the reasons
def list_invalid_properties
invalid_properties = Array.new
if @category.nil?
invalid_properties.push('invalid value for "category", category cannot be nil.')
end

if @_end.nil?
invalid_properties.push('invalid value for "_end", _end cannot be nil.')
end

if @start.nil?
invalid_properties.push('invalid value for "start", start cannot be nil.')
end

if @timezone.nil?
invalid_properties.push('invalid value for "timezone", timezone cannot be nil.')
end

invalid_properties
end

# Check to see if the all the properties in the model are valid
# @return true if the model is valid
def valid?
return false if @category.nil?
return false if @_end.nil?
return false if @start.nil?
return false if @timezone.nil?
true
end

Expand Down