Skip to content

Fix object deserialization for undo actions #3030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2025
Merged

Fix object deserialization for undo actions #3030

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions features/support/undo.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
import fs from "fs";
import path from "path";
import log from "loglevel";

import { getProperty, pathLookup } from "./templating";
import { ScenariosModelMappings } from "./scenarios_model_mapping";
import * as datadogApiClient from "../../index";

import log from "loglevel";
const logger = log.getLogger("testing")
logger.setLevel(process.env.DEBUG ? logger.levels.DEBUG : logger.levels.INFO);


interface iOperationParameter {
name: string;
origin: string;
Expand Down Expand Up @@ -99,14 +100,19 @@ function buildUndoFor(
opts[p.name.toAttributeName()] = pathLookup(dataSource, p.source);
} else if (p.template !== undefined) {
const data = JSON.parse(p.template.templated(dataSource));
const param: { [key: string]: any } = {};
for (const [key, value] of Object.entries(data)) {
param[key.toAttributeName()] = value;
}
opts[p.name.toAttributeName()] = param;
opts[p.name.toAttributeName()] = data;
}
}

const objectSerializer = getProperty(datadogApiClient, apiVersion).ObjectSerializer;
Object.keys(opts).forEach(key => {
opts[key] = objectSerializer.deserialize(
opts[key],
ScenariosModelMappings[`${apiVersion}.${operationUndo.undo.operationId}`][key].type,
ScenariosModelMappings[`${apiVersion}.${operationUndo.undo.operationId}`][key].format
)
});

try {
await apiInstance[operationName](opts);
} catch (error) {
Expand Down
Loading