Add metrics and logs integration testing #2
Conversation
maxday
changed the title
maxday
changed the title
integration_tests/serverless.yml
Outdated
| runtime: nodejs12.x | ||
| handler: src/metric.enhancedMetricTest | ||
| layers: | ||
| - arn:aws:lambda:${self:provider.region}:601427279990:layer:Datadog-Node12-x:${env:LAYER_VERSION} |
There was a problem hiding this comment.
I think we should pull the Node layer from the prod account (464622532012). That way we are testing the development version of the extension with the production Lambda Library.
| AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} | ||
| AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||
| # Todo : retrieve this layer version automatically from AWS | ||
| LAYER_VERSION: 6 |
There was a problem hiding this comment.
I would rename this to NODE_LAYER_VERSION to make it more clear which layer we are talking about here.
There was a problem hiding this comment.
✅ as we'll add more functions in different languages soon
integration_tests/src/metric.js
Outdated
|
|
||
| async function myTimeoutHandler(event, context) { | ||
| sendDistributionMetric("serverless.lambda-extension.integration-test.count", invocationCount); | ||
| await new Promise(r => setTimeout(r, 30*1000)); //30 sec to be sure |
There was a problem hiding this comment.
Nit: For testing timeouts, I prefer to create an infinite loop. That way, the function will definitely time out no matter how I adjust the Lambda timeout setting.
There was a problem hiding this comment.
I've adjust it with the max AWS allowed timeout value ✅
| @@ -0,0 +1,59 @@ | |||
| name: build | |||
|
|
|||
| on: push | |||
There was a problem hiding this comment.
Weren't we going to run this hourly? Where is that set up?
There was a problem hiding this comment.
Also, if the tests fail, will we be notified somehow?
nhinsch
left a comment
nhinsch
left a comment
There was a problem hiding this comment.
This looks great! 💯
I left a few last-minute questions about the GitHub action.
This PR bootstraps the integration tests setup for metrics and logs with the followings scenarios :