Skip to content

Conversation

@nhinsch
Copy link
Contributor

@nhinsch nhinsch commented Oct 25, 2021

Regenerates the snapshots to reflect the latest changes to the Lambda Extension.

Also, fix some issues with the integration tests:

  • Only build the amd64 version of the extension. Right now we don't have any tests that use the arm64 extension so it's a waste of time to build it. In the future, we could add tests for arm64 and parallelize the builds/tests.
  • Fix the behavior of boolean arguments. Previously, some boolean arguments like BUILD_EXTENSION=true used the -n operator which checks for a non-empty string. This means that BUILD_EXTENSION=false would be interpreted as true because "false" is a non-empty string. This PR fixes that behavior.
  • Stop testing with sandbox Lambda Layers. Previously, we tested the extension with the latest versions of the runtime Lambda layers from the sandbox account. However, because this account is a test environment, there was no guarantee that we were using layers that would behave as expected. This PR updates the tests to use layers from the production account. Because it's harder to get the latest layer version across accounts, the tests default to a hardcoded layer version. If we don't keep this fully up-to-date, it's not the end of the world, because the extension is supposed to work with older versions of the Lambda Layers anyway.

@nhinsch nhinsch marked this pull request as ready for review October 25, 2021 22:10
@nhinsch nhinsch requested a review from a team as a code owner October 25, 2021 22:10
}


if [ $ARCHITECTURE == "amd64" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oups sorry about that :)

@maxday maxday self-requested a review October 27, 2021 21:30
Copy link
Contributor

@maxday maxday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
(I think layer 65 is available for NodeJS if you want to update it right now, otherwise let's merge it!)

@nhinsch nhinsch merged commit 082563b into main Oct 27, 2021
@nhinsch nhinsch deleted the ngh/improve-tests branch October 27, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants