Skip to content

Conversation

@DarcyRaynerDD
Copy link
Contributor

What does this PR do?

Adds support to detect step function events, and inject relevant metadata into X-Ray and Datadog traces

Motivation

Testing Guidelines

Additional Notes

@DarcyRaynerDD DarcyRaynerDD requested a review from a team as a code owner October 24, 2019 16:07
@codecov-io
Copy link

codecov-io commented Oct 24, 2019

Codecov Report

Merging #29 into master will increase coverage by 0.28%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage    89.8%   90.09%   +0.28%     
==========================================
  Files          21       21              
  Lines         510      555      +45     
  Branches       76       88      +12     
==========================================
+ Hits          458      500      +42     
- Misses         32       34       +2     
- Partials       20       21       +1
Impacted Files Coverage Δ
src/trace/constants.ts 100% <100%> (ø) ⬆️
src/trace/trace-context-service.ts 81.81% <50%> (-3.9%) ⬇️
src/trace/listener.ts 87.09% <50%> (-5.77%) ⬇️
src/trace/context.ts 97.32% <97.56%> (+1.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b2f1bb...c62b5bd. Read the comment docs.

Copy link
Contributor

@swfunc swfunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DarcyRaynerDD DarcyRaynerDD merged commit 6b94ed5 into master Oct 25, 2019
@DarcyRaynerDD DarcyRaynerDD deleted the darcy.rayner/step-function-support-poc branch October 25, 2019 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants