Skip to content

Conversation

@DarcyRaynerDD
Copy link
Contributor

@DarcyRaynerDD DarcyRaynerDD commented Mar 31, 2021

What does this PR do?

Adds a check to PRs that will reject if a layer size exceeds a certain threshold, (both compressed and uncompressed).

Motivation

Prevent accidental layer sizing drift.

Testing Guidelines

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@DarcyRaynerDD DarcyRaynerDD requested a review from a team as a code owner March 31, 2021 14:10
@DarcyRaynerDD DarcyRaynerDD merged commit 5c20efc into main Mar 31, 2021
@DarcyRaynerDD DarcyRaynerDD deleted the darcy.rayner/layer-size-on-pr branch March 31, 2021 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants