Add lambda function url trigger and inferred span #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hghotra
reviewed
Nov 19, 2021
Co-authored-by: Harvinder Ghotra <ghotra.harvinder@gmail.com>
hghotra
reviewed
Nov 19, 2021
hghotra
reviewed
Nov 19, 2021
hghotra
reviewed
Nov 19, 2021
datadog_lambda/wrapper.py
Outdated
| self.inferred_span = None | ||
| self.make_inferred_span = ( | ||
| os.environ.get("DD_INFERRED_SPANS", "false").lower() == "true" | ||
| and should_use_extension |
Contributor
There was a problem hiding this comment.
We can remove this check, the Forwarder should work as expected with this.
hghotra
reviewed
Nov 19, 2021
hghotra
reviewed
Nov 19, 2021
hghotra
reviewed
Nov 19, 2021
hghotra
reviewed
Nov 19, 2021
hghotra
approved these changes
Nov 19, 2021
Contributor
hghotra
left a comment
hghotra
left a comment
There was a problem hiding this comment.
Left a few nits - but looks amazing 💯
Co-authored-by: Harvinder Ghotra <ghotra.harvinder@gmail.com>
Co-authored-by: Harvinder Ghotra <ghotra.harvinder@gmail.com>
Co-authored-by: Harvinder Ghotra <ghotra.harvinder@gmail.com>
Co-authored-by: Harvinder Ghotra <ghotra.harvinder@gmail.com>
Co-authored-by: Harvinder Ghotra <ghotra.harvinder@gmail.com>
Co-authored-by: Harvinder Ghotra <ghotra.harvinder@gmail.com>
…thub.com:DataDog/datadog-lambda-python into chris.agocs/lambda_function_url_trigger_and_span
agocs
added a commit
that referenced
this pull request
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Testing Guidelines
Additional Notes
Types of Changes
Check all that apply