Upgrade AWS X-Ray SDK #58
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianchu
approved these changes
Apr 15, 2020
Author
|
@tianchu Is it possible to make a release now? |
Author
It would be great if you made a release now since I need to raise one more PR in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please remember to review the contribution guidelines
if you have not yet done so.
What does this PR do?
This PR upgrades the version of AWS X-Ray SDK to v2.5.0
Motivation
I have recently submitted patch support for
PyMySQL(client library for MySQL) in X-Ray SDK #214 which is merged and released in XRay SDK v2.5.0.After upgrading our serverless application with the latest version of SDK, got errors from Xray SDK that
pymysqlwas not a supported module. I raised a request in the SDK repo #219. Upon further investigation, I found out that Datadog's layer is overriding the SDK version in our deployment package. We also use lambda layers to package our dependencies. Upgrading AWS Xray SDK to v2.5.0 in Datadog's layer will solve this issue for us.Testing Guidelines
How did you test this pull request?
I ran
./scripts/run_tests.shAdditional Notes
It's important that this gets merged soon as our application is dependent on it and we need MySQL instrumentation support as quickly as possible.
Checklist