-
Notifications
You must be signed in to change notification settings - Fork 394
feat(aws): Add scheduled invocation for retry event #1027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Vincent Boutour <vincent.boutour@datadoghq.com>
Signed-off-by: Vincent Boutour <vincent.boutour@datadoghq.com>
| init_cache_layer(function_prefix) | ||
| init_forwarder(function_prefix) | ||
|
|
||
| if len(event) == 1 and str(event.get(DD_RETRY_KEYWORD, "false")).lower() == "true": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in which cases would we receive a len(event) > 1 AFAIK the forwarder is always triggered by a single event which could include several logs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, but we want to launch the retry only mode in the very specific {"retry":true} event.
For example if SQS or async invocation of the lambda add this kind of entry in the received event, we'll do both the retry failed events and processing the event.
To avoid forwarding this specific event (the {"retry":true}), we exit the function when it's the case, so I want to clearly identify this event.
Co-authored-by: Georgi <georgi.ajaeiya@datadoghq.com>
Signed-off-by: Vincent Boutour <vincent.boutour@datadoghq.com>
janine-c
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions here to keep this more in line with how docs are typically written, but no showstoppers 🙂
Co-authored-by: Janine Chan <64388808+janine-c@users.noreply.github.com>
Signed-off-by: Vincent Boutour <vincent.boutour@datadoghq.com>
…eduler Signed-off-by: Vincent Boutour <vincent.boutour@datadoghq.com>
What does this PR do?
Motivation
Testing Guidelines
Additional Notes
Types of changes
Check all that apply