Skip to content

Conversation

@ViBiOh
Copy link
Contributor

@ViBiOh ViBiOh commented Nov 26, 2025

What does this PR do?

Motivation

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

Signed-off-by: Vincent Boutour <vincent.boutour@datadoghq.com>
@github-actions github-actions bot added the aws label Nov 26, 2025
Signed-off-by: Vincent Boutour <vincent.boutour@datadoghq.com>
@ViBiOh ViBiOh marked this pull request as ready for review November 27, 2025 10:33
@ViBiOh ViBiOh requested review from a team as code owners November 27, 2025 10:33
@ge0Aja ge0Aja self-assigned this Nov 27, 2025
init_cache_layer(function_prefix)
init_forwarder(function_prefix)

if len(event) == 1 and str(event.get(DD_RETRY_KEYWORD, "false")).lower() == "true":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in which cases would we receive a len(event) > 1 AFAIK the forwarder is always triggered by a single event which could include several logs

Copy link
Contributor Author

@ViBiOh ViBiOh Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, but we want to launch the retry only mode in the very specific {"retry":true} event.

For example if SQS or async invocation of the lambda add this kind of entry in the received event, we'll do both the retry failed events and processing the event.

To avoid forwarding this specific event (the {"retry":true}), we exit the function when it's the case, so I want to clearly identify this event.

Co-authored-by: Georgi <georgi.ajaeiya@datadoghq.com>
@ViBiOh ViBiOh requested a review from ge0Aja November 27, 2025 14:16
Signed-off-by: Vincent Boutour <vincent.boutour@datadoghq.com>
Copy link
Contributor

@janine-c janine-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions here to keep this more in line with how docs are typically written, but no showstoppers 🙂

ViBiOh and others added 3 commits November 27, 2025 18:19
Co-authored-by: Janine Chan <64388808+janine-c@users.noreply.github.com>
Signed-off-by: Vincent Boutour <vincent.boutour@datadoghq.com>
…eduler

Signed-off-by: Vincent Boutour <vincent.boutour@datadoghq.com>
@ViBiOh ViBiOh merged commit 009beda into master Nov 28, 2025
11 checks passed
@ViBiOh ViBiOh deleted the vibioh/scheduled_invocation branch November 28, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants